#50: Added shallow abstraction for boto3 #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s needed by this project - Moved AwcAccess under module aws
… wrong usage of methods of the mocked class
…ngs left by the split from the timeout PR
|
Integration test for the shallow abstraction will be implemented with a separate ticket #52. For that reason, please review the boto calls very thoroughly |
Nicoretti
reviewed
Jun 13, 2023
exasol_script_languages_container_ci_setup/lib/aws/wrapper/cloudformation_service.py
Outdated
Show resolved
Hide resolved
exasol_script_languages_container_ci_setup/lib/aws/wrapper/codebuild_service.py
Outdated
Show resolved
Hide resolved
exasol_script_languages_container_ci_setup/lib/aws/wrapper/datamodels/codebuild.py
Show resolved
Hide resolved
exasol_script_languages_container_ci_setup/lib/aws/wrapper/datamodels/codebuild.py
Show resolved
Hide resolved
exasol_script_languages_container_ci_setup/lib/aws/wrapper/datamodels/common.py
Outdated
Show resolved
Hide resolved
exasol_script_languages_container_ci_setup/lib/aws/wrapper/datamodels/common.py
Show resolved
Hide resolved
exasol_script_languages_container_ci_setup/lib/aws/wrapper/secretsmanager_service.py
Outdated
Show resolved
Hide resolved
test/unit_tests/aws/wrapper/datamodels/secretsmanager/test_secret.py
Outdated
Show resolved
Hide resolved
test/unit_tests/aws/wrapper/datamodels/secretsmanager/test_secret.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Nicola Coretti <[email protected]>
Nicoretti
approved these changes
Jun 16, 2023
Comment on lines
+7
to
+36
| def test_arn_exists(): | ||
| expected = Secret(arn=ARN(aws_arn="EXPECTED_ARN")) | ||
| boto_secret = {"ARN": expected.arn.aws_arn} | ||
| actual = Secret.from_boto(boto_secret) | ||
| assert actual.arn == expected.arn | ||
|
|
||
|
|
||
| def test_arn_not_exists(): | ||
| with pytest.raises(KeyError): | ||
| boto_secret = {} | ||
| secret = Secret.from_boto(boto_secret) | ||
|
|
||
|
|
||
| def test_with_extra_keys(): | ||
| expected = Secret(arn=ARN(aws_arn="EXPECTED_ARN")) | ||
| boto_secret = { | ||
| "ARN": expected.arn.aws_arn, | ||
| "extra1": None, | ||
| "extra2": 1 | ||
| } | ||
| actual = Secret.from_boto(boto_secret) | ||
| assert actual == expected | ||
|
|
||
|
|
||
| def test_empty_arn(): | ||
| with pytest.raises(ValueError, match="ARN was None"): | ||
| boto_secret = { | ||
| "ARN": None | ||
| } | ||
| secret = Secret.from_boto(boto_secret) |
There was a problem hiding this comment.
In cases you expect further tests here, they could be rewritten to be parameterized tests. One group of parameterized test for the exception based test and another for the value based ones.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #50